Change base_name and pretty_name fields in contract symbols to match the contract name. #1491
Merged
monal merged 2 commits intomodel-checking:features/function-contractsfrom Aug 11, 2022
Conversation
added 2 commits
August 11, 2022 05:51
…(Based on CBMC's implementation change)
monal
changed the title
monal
changed the title
monal
changed the title
zhassan-aws
approved these changes
Aug 11, 2022
zhassan-aws
pushed a commit
to zhassan-aws/kani
that referenced
this pull request
May 26, 2023
…the contract name. (model-checking#1491) * Change contract symbol's base_name and pretty_name to match its name (Based on CBMC's implementation change) * Remove unused generic param Co-authored-by: Monal Narasimhamurthy <monaln@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Changing
base_nameandpretty_nameto match thenamefield in a contract symbol. Hence, all three names will now be of the formcontract::<foo>, where<foo>refers to the function name.The change is due to a corresponding change in CBMC for a bugfix. See diffblue/cbmc#7063 for more details.
Resolved issues:
Call-outs:
Testing:
The code won't be merged into main until we have test cases.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.