Skip to content

Add an __VERIFIER_expected_fail() intrinsic, and use it in a test#229

Merged
adpaco-aws merged 3 commits intomodel-checking:main-152-2021-06-17from
danielsn:expect-fail
Jun 20, 2021
Merged

Add an __VERIFIER_expected_fail() intrinsic, and use it in a test#229
adpaco-aws merged 3 commits intomodel-checking:main-152-2021-06-17from
danielsn:expect-fail

Conversation

@danielsn
Copy link
Copy Markdown
Contributor

@danielsn danielsn commented Jun 17, 2021

Description of changes:

Currently, we check for expected failing assertions by marking the whole test as _fail. This is not very granular.

Resolved issues:

Resolves #228

Call-outs:

We have a field for custom error messages, but due to the inability of CBMC to take non-constant assertion messages, we can't yet use them.

Testing:

  • How is this change tested? Used it in a test, test still fails

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws merged commit cdc44b5 into model-checking:main-152-2021-06-17 Jun 20, 2021
adpaco-aws pushed a commit that referenced this pull request Jun 23, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
adpaco-aws pushed a commit that referenced this pull request Jul 2, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
adpaco-aws pushed a commit that referenced this pull request Jul 9, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
adpaco-aws pushed a commit that referenced this pull request Jul 15, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
adpaco-aws pushed a commit that referenced this pull request Jul 26, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
adpaco-aws pushed a commit that referenced this pull request Aug 2, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
@zhassan-aws zhassan-aws mentioned this pull request Aug 6, 2021
4 tasks
adpaco-aws pushed a commit that referenced this pull request Aug 6, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
adpaco-aws pushed a commit that referenced this pull request Aug 17, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
adpaco-aws pushed a commit that referenced this pull request Aug 24, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
@danielsn danielsn deleted the expect-fail branch September 24, 2021 21:33
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
…del-checking#229)

* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
tedinski pushed a commit that referenced this pull request Apr 27, 2022
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test

* PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It should be possible to have assertions which are expected to fail in RMC tests

2 participants