Add an __VERIFIER_expected_fail() intrinsic, and use it in a test#229
Merged
adpaco-aws merged 3 commits intomodel-checking:main-152-2021-06-17from Jun 20, 2021
Merged
Conversation
adpaco-aws
suggested changes
Jun 18, 2021
adpaco-aws
approved these changes
Jun 20, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Jun 23, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 2, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 9, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 6, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 17, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 24, 2021
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
…del-checking#229) * Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Add an __VERIFIER_expected_fail() intrinsic, and use it in a test * PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, we check for expected failing assertions by marking the whole test as
_fail. This is not very granular.Resolved issues:
Resolves #228
Call-outs:
We have a field for custom error messages, but due to the inability of CBMC to take non-constant assertion messages, we can't yet use them.
Testing:
How is this change tested? Used it in a test, test still fails
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.