Propogate solver options into synthesizer#2320
Merged
qinheping merged 2 commits intomodel-checking:mainfrom Apr 7, 2023
Merged
Propogate solver options into synthesizer#2320qinheping merged 2 commits intomodel-checking:mainfrom
qinheping merged 2 commits intomodel-checking:mainfrom
Conversation
zhassan-aws
approved these changes
Mar 27, 2023
Contributor
zhassan-aws
left a comment
zhassan-aws
left a comment
There was a problem hiding this comment.
Looks good. This will need to wait for the next CBMC version bump before merging though.
karkhaz
added a commit
to karkhaz/kani
that referenced
this pull request
Apr 19, 2023
* The Kani reference now includes an ["Attributes"](https://model-checking.github.io/kani/reference/attributes.html) section that describes each of the attributes available in Kani ([pull request](model-checking#2359) by @adpaco-aws) * Users' choice of SAT solver, specified by the `solver` attribute, is now propagated to the loop-contract synthesizer ([pull request](model-checking#2320) by @qinheping) * Unit tests generated by the concrete playback feature now compile correctly when using `RUSTFLAGS="--cfg=kani"` ([pull request](model-checking#2353) by @jaisnan) * The Rust toolchain is updated to 2023-02-18 ([pull request](model-checking#2384) by @tautschnig)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
As
goto-synthesizernow support solver options (CBMC#7612). We should also propagate solver options into the synthesizer in Kani.Resolved issues:
Resolves #ISSUE-NUMBER
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.