Delete Generator/discriminant test#2334
Merged
karkhaz merged 1 commit intomodel-checking:mainfrom Apr 3, 2023
Merged
Conversation
This test is flaky in CI; removing until we can diagnose and fix the failure.
qinheping
previously approved these changes
Apr 3, 2023
Contributor
|
Can we instead make it a fixme test and create an issue to remind us to fix it later? https://model-checking.github.io/kani/regression-testing.html#fixme-tests |
Haven't read the slack message before approval
Contributor
Author
|
I'm not sure if fixme would work here because the test is flaky. It sometimes appears to memout in CI, but otherwise works. So we can't add an expected result I think... |
Contributor
|
I agree adding But, as @qinheping pointed out, can we at least file an issue to track re-enabling this test? |
Contributor
Author
|
Yes, opened #2337 |
zhassan-aws
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is flaky in CI; removing until we can diagnose and fix the failure.
Description of changes:
Describe Kani's current behavior and how your code changes that behavior. If there are no issues this PR is resolving, explain why this change is necessary.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.