Skip to content

Fix playback with build scripts#2477

Merged
celinval merged 2 commits intomodel-checking:mainfrom
celinval:issue-xxxx-playback-build
May 26, 2023
Merged

Fix playback with build scripts#2477
celinval merged 2 commits intomodel-checking:mainfrom
celinval:issue-xxxx-playback-build

Conversation

@celinval
Copy link
Copy Markdown
Contributor

Description of changes:

I'm not 100% sure on why we need to set target, but without it, cargo is not properly running the build scripts as part of playback subcommand. I added that + made sure we propagate RUSTFLAGS to playback as well.

Resolved issues:

N/A

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Adding --target also caused compilation for our tests to generate an extra artifact. Thus, I had to change an existing test.

Testing:

  • How is this change tested? New test

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval requested a review from a team as a code owner May 25, 2023 21:19
Copy link
Copy Markdown
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@celinval celinval enabled auto-merge (squash) May 26, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants