Add flag to the compiler to build std library (no user visible change)#2676
Merged
celinval merged 3 commits intomodel-checking:mainfrom Aug 15, 2023
Merged
Add flag to the compiler to build std library (no user visible change)#2676celinval merged 3 commits intomodel-checking:mainfrom
celinval merged 3 commits intomodel-checking:mainfrom
Conversation
When building the standard library, we cannot assume that Kani elements or standard library elements are available. This flag allow us to control that.
Contributor
|
I'm not sure I see what this change is doing. Can you expand the description and/or the comments in the code to clarify? |
Contributor
Author
I updated the description. Let me know if that makes sense now. |
Contributor
|
Yes, it does. Thanks! |
zhassan-aws
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Parts of the compiler relies on the existence of some constructs that are available in the standard library and Kani library. However, they aren't available when we are actually building the standard library (
std-lib-regression.sh) and the Kani libraries (when building the sysroot withcargo build-dev).Thus, we introduce a flag to inform the compiler that we are currently building the standard library. This flag can then be used to properly enable / disable sysroot dependent code.
Resolved issues:
N/A
Related RFC:
Call-outs:
This is related to the bitmask work.
Testing:
How is this change tested? Existing tests
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.