Create workflow Kani Extra for checks that run conditionally on labels#2837
Merged
celinval merged 3 commits intomodel-checking:mainfrom Oct 26, 2023
Merged
Create workflow Kani Extra for checks that run conditionally on labels#2837celinval merged 3 commits intomodel-checking:mainfrom
celinval merged 3 commits intomodel-checking:mainfrom
Conversation
The "Auto Label" workflow correctly label our PRs; however, this action do not trigger a PR 'labeled' workflow. To automatically do that, we now changed the CI structure to have a new workflow with extra jobs that are conditional to labels and files being modified. This new workflow starts by triggering the auto-label job. The benchmark workflow is only triggered if after the auto-label job, the PR has a Z-BenchCI label. This also means that the benchmark workflow will now run after any update to a PR that has the 'Z-BenchCI' label.
jaisnan
approved these changes
Oct 26, 2023
Contributor
jaisnan
left a comment
jaisnan
left a comment
There was a problem hiding this comment.
Awesome change! Thank you
Contributor
Is this a unwanted side-effect? I thought this was the intention behind this change? |
Contributor
Author
Not a side effect. I just wanted to call out that this is more than just refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Auto Label" workflow correctly label our PRs; however, this action do not trigger a PR 'labeled' workflow. To automatically do that, we now changed the CI structure to have a new workflow with extra jobs that are conditional to labels and files being modified.
This new workflow starts by triggering the auto-label job. The benchmark workflow is only triggered if after the auto-label job, the PR has a Z-BenchCI label.
This also means that the benchmark workflow will now run after any update to a PR that has the 'Z-BenchCI' label.
Resolves #2606
Call-out
I manually tested these changes in my branch with this dummy PR: celinval#19. The new workflow can be seen here and the benchcomp run shows up in the list of job as "Kani Extra / Verification Benchmarks / perf-benchcomp".
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.