Custom panic hook for RMC including current item#304
Merged
danielsn merged 4 commits intomodel-checking:main-153-2021-07-02from Jul 8, 2021
Merged
Custom panic hook for RMC including current item#304danielsn merged 4 commits intomodel-checking:main-153-2021-07-02from
danielsn merged 4 commits intomodel-checking:main-153-2021-07-02from
Conversation
danielsn
reviewed
Jul 7, 2021
Contributor
There was a problem hiding this comment.
Is there a more descriptive name to use here?
Contributor
There was a problem hiding this comment.
We should reset the item at the end, to avoid spuriously having a set item if there is none. We could use a RAII pattern, tho that might be overkill
Contributor
Author
There was a problem hiding this comment.
Done, reset after both loops.
Contributor
Author
There was a problem hiding this comment.
Not sure what exactly RAII would look like here, feel free to follow up if this change is not sufficient?
7aa4cec to
55fb5b4
Compare
4 tasks
danielsn
suggested changes
Jul 8, 2021
danielsn
approved these changes
Jul 8, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 9, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 15, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Jul 26, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 2, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 6, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 17, 2021
adpaco-aws
pushed a commit
that referenced
this pull request
Aug 24, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
When RMC panics currently, you get the standard Rustc panic message, including a link to their bug reporting. Add a custom panic hook with our bug template link and include the current codegen item (usually function) causing the problem.
Example panic now:
Resolved issues:
Resolves #287
Call-outs:
Unfortunately, we can't use the same approach Cranelift uses to remove rustc's bug report link, since that would introduce a circular dependency on
rustc_driver. Adding a comment explaining that.Testing:
Manually introducing panics.
No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.