Merged
Conversation
jaisnan
reviewed
Sep 4, 2024
Contributor
jaisnan
left a comment
jaisnan
left a comment
There was a problem hiding this comment.
Almost there! Just a few small points left to address
jaisnan
approved these changes
Sep 4, 2024
Contributor
jaisnan
left a comment
jaisnan
left a comment
There was a problem hiding this comment.
Approving under the assumption that the schemas will be added to documentation sooner rather than later 👍
Contributor
Author
@jaisnan Yes, I'll make sure that the first release of this has schema documentation. |
celinval
approved these changes
Sep 6, 2024
celinval
reviewed
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses @jaisnan's feedback on list RFC--change
humanoutput toprettyand fix Kani version typo.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.