Skip to content

Fix dry-run to print to stdout when output_to is not stdout. #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielsn merged 1 commit into from
Jul 28, 2021
Merged

Fix dry-run to print to stdout when output_to is not stdout. #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/rmc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,12 @@ def run_cmd(cmd, label=None, cwd=None, env=None, output_to=None, quiet=False, ve
# If this a dry run, we emulate running a successful process whose output is the command itself
# We set `output_to` to `stdout` so that the output is not omitted below
if dry_run:
if output_to == None:
output_to = "stdout"
cmd_line = ' '.join(cmd)
if output_to != "stdout" and output_to is not None:
cmd_line += f" > \"{output_to}\""

output_to = "stdout"

process = subprocess.CompletedProcess(None, EXIT_CODE_SUCCESS, stdout=cmd_line)
else:
process = subprocess.run(
Expand Down