Skip to content

Fix failing codegen in due to incorrect boolean types#396

Closed
chinmaydd wants to merge 2 commits intomodel-checking:main-154-2021-08-02from
chinmaydd:bool-fix
Closed

Fix failing codegen in due to incorrect boolean types#396
chinmaydd wants to merge 2 commits intomodel-checking:main-154-2021-08-02from
chinmaydd:bool-fix

Conversation

@chinmaydd
Copy link

Description of changes:

RMC fails in codegen when generating expression with boolean XOR if the type of operands is CInteger(Bool) as CBMC requires them to be Bool (https://github.com/diffblue/cbmc/blob/develop/src/solvers/prop/prop_conv_solver.cpp#L194)

Resolved issues:

Resolves #394

Call-outs:

None

Testing:

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@chinmaydd
Copy link
Author

chinmaydd commented Aug 6, 2021

Oh, I did not see #395. I guess this PR can be closed in favor of its replacement.

@chinmaydd chinmaydd closed this Aug 6, 2021
@chinmaydd chinmaydd deleted the bool-fix branch August 9, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic with a bitwise xor operator

1 participant