Fix failing codegen in due to incorrect boolean types#396
Closed
chinmaydd wants to merge 2 commits intomodel-checking:main-154-2021-08-02from
Closed
Fix failing codegen in due to incorrect boolean types#396chinmaydd wants to merge 2 commits intomodel-checking:main-154-2021-08-02from
chinmaydd wants to merge 2 commits intomodel-checking:main-154-2021-08-02from
Conversation
Author
|
Oh, I did not see #395. I guess this PR can be closed in favor of its replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
RMC fails in codegen when generating expression with boolean XOR if the type of operands is
CInteger(Bool)as CBMC requires them to beBool(https://github.com/diffblue/cbmc/blob/develop/src/solvers/prop/prop_conv_solver.cpp#L194)Resolved issues:
Resolves #394
Call-outs:
None
Testing:
How is this change tested?
Created a new test case out of Panic with a bitwise xor operator #394
Is this a refactor change?
No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.