Skip to content

Removed incorrect special case for Rust bitwise operators#403

Merged
zhassan-aws merged 1 commit intomodel-checking:main-154-2021-08-06from
zhassan-aws:fix-bit-logic-operators2
Aug 7, 2021
Merged

Removed incorrect special case for Rust bitwise operators#403
zhassan-aws merged 1 commit intomodel-checking:main-154-2021-08-06from
zhassan-aws:fix-bit-logic-operators2

Conversation

@zhassan-aws
Copy link
Copy Markdown
Contributor

@zhassan-aws zhassan-aws commented Aug 6, 2021

Description of changes:

RMC crashes in codegen for logic operators (And, Or, Xor) applied on bool types.

Resolved issues:

Resolves #394

Call-outs:

None.

Testing:

  • How is this change tested?
    Added a new test in the commit: src/test/cbmc/BitwiseArithOperators/bool.rs

  • Is this a refactor change?
    No.

Checklist

  • [X ] Each commit message has a non-empty body, explaining why the change was made
  • [X ] Methods or procedures are documented
  • [X ] Regression or unit tests are included, or existing tests cover the modified code
  • [X ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@avanhatt
Copy link
Copy Markdown
Contributor

avanhatt commented Aug 6, 2021

Looks good! Reminder to @zhassan-aws to fill in the template on this page (doesn't need to have every section, just a description of what you changed and the issue #).

@zhassan-aws
Copy link
Copy Markdown
Contributor Author

Looks good! Reminder to @zhassan-aws to fill in the template on this page (doesn't need to have every section, just a description of what you changed and the issue #).

Done.

@zhassan-aws zhassan-aws merged commit 8b4ab4c into model-checking:main-154-2021-08-06 Aug 7, 2021
@zhassan-aws zhassan-aws deleted the fix-bit-logic-operators2 branch August 7, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic with a bitwise xor operator

3 participants