Add support for modifying examples in the Rust books.#447
Merged
adpaco-aws merged 2 commits intomodel-checking:main-154-2021-08-24from Aug 31, 2021
Merged
Add support for modifying examples in the Rust books.#447adpaco-aws merged 2 commits intomodel-checking:main-154-2021-08-24from
adpaco-aws merged 2 commits intomodel-checking:main-154-2021-08-24from
Conversation
Signed-off-by: Abdalrhman M Mohamed <bdalrhm@amazon.com>
Signed-off-by: Abdalrhman M Mohamed <bdalrhm@amazon.com>
adpaco-aws
changed the base branch from
main-154-2021-08-17
to
main-154-2021-08-24
adpaco-aws
approved these changes
Aug 31, 2021
tedinski
approved these changes
Aug 31, 2021
|
|
||
| #[derive(Clone, Default)] | ||
| crate struct TestOptions { | ||
| pub struct TestOptions { |
Contributor
There was a problem hiding this comment.
I think my only concern is the potential for future conflicts from stuff like this, but if it's fine with your Adrian, then it's fine with me.
Contributor
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
…#447) * Add support for modifying examples in the Rust books. Signed-off-by: Abdalrhman M Mohamed <bdalrhm@amazon.com> * Punctuation. Signed-off-by: Abdalrhman M Mohamed <bdalrhm@amazon.com>
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Add support for modifying examples in the Rust books. Signed-off-by: Abdalrhman M Mohamed <bdalrhm@amazon.com> * Punctuation. Signed-off-by: Abdalrhman M Mohamed <bdalrhm@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds support for modifying examples in the Rust books by adding a diff file with the same name as the example in
src/tools/dashboard/configs.Resolved issues:
Resolves #408
Call-outs:
To avoid duplicating code, the dashboard now depends on some of
rustdoc's internal API, some of which were made public as necessary.Testing:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.