Fix rmc codegen to check for no-codegen option#601
Merged
celinval merged 1 commit intomodel-checking:mainfrom Oct 29, 2021
Merged
Fix rmc codegen to check for no-codegen option#601celinval merged 1 commit intomodel-checking:mainfrom
celinval merged 1 commit intomodel-checking:mainfrom
Conversation
RMC code generation was creating artifacts even if rustc was run with -Z no-codegen. I changed the codegen to check for this option before writing the json files. This issue was uncovered by my change to move the rmc flags to rmc-rustc. This script is used during compiletest. In the check stage, the test runs rustc with --no-codegen.
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
RMC code generation was creating artifacts even if rustc was run with -Z no-codegen. I changed the codegen to check for this option before writing the json files. This issue was uncovered by my change to move the rmc flags to rmc-rustc. This script is used during compiletest. In the check stage, the test runs rustc with --no-codegen.
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
RMC code generation was creating artifacts even if rustc was run with -Z no-codegen. I changed the codegen to check for this option before writing the json files. This issue was uncovered by my change to move the rmc flags to rmc-rustc. This script is used during compiletest. In the check stage, the test runs rustc with --no-codegen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
RMC code generation was creating artifacts even if rustc was run with
-Z no-codegen. I changed the codegen to check for this option before
writing the json files.
This issue was uncovered by my change to move the rmc flags to
rmc-rustc. This script is used during compiletest. In the check stage,
the test runs rustc with --no-codegen.
Call-outs:
This code will be tested once we merge #597 PR.
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.