Reduce compiletest code for easier decoupling#694
Merged
adpaco-aws merged 4 commits intomodel-checking:mainfrom Dec 22, 2021
Merged
Reduce compiletest code for easier decoupling#694adpaco-aws merged 4 commits intomodel-checking:mainfrom
adpaco-aws merged 4 commits intomodel-checking:mainfrom
Conversation
celinval
suggested changes
Dec 14, 2021
Contributor
celinval
left a comment
There was a problem hiding this comment.
That's awesome! I would prefer if we copy the heavily modified compiletest to a different location and keep the current one as is. I'm worried that this may make the next upstream synchronization much harder.
6de4bb6 to
189966e
Compare
Contributor
Author
|
Copied the original proposal into |
9191040 to
a81cf50
Compare
a81cf50 to
4beaac0
Compare
Contributor
Author
|
Went back to the original proposal. Added "modifications" copyright notices for each file. |
celinval
approved these changes
Dec 22, 2021
Contributor
celinval
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Reduce compiletest code for easier decoupling * Add modifications copyright * Remove unused function `get_lib_name`
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Reduce compiletest code for easier decoupling * Add modifications copyright * Remove unused function `get_lib_name`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactors the compiletest tool to remove most code not used in this project while still keeping its major features (suite testing, caching, concurrency). This allows us to decouple from the compiler anytime in the future.
For comparison, this is the
clocoutput onsrc/tools/compiletest(branchmain):The output including the changes in this PR:
So about 78% (1345/6606) of the code has been remove.
Note that option parsing has been changed to make all arguments optional so the tool still works when called from
x.py. Most code there will be removed at the time of decoupling.Noticed that #289 is not an issue anymore (probably due to other changes in
rmc.py). Removed the code to disable related checks and reference to the issue.Resolved issues:
Resolves #289
Call-outs:
Testing:
How is this change tested? Running existing regression.
Is this a refactor change? Yes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.