Add CI script to check for bookrunner failures#868
Merged
celinval merged 4 commits intomodel-checking:mainfrom Feb 26, 2022
Merged
Add CI script to check for bookrunner failures#868celinval merged 4 commits intomodel-checking:mainfrom
celinval merged 4 commits intomodel-checking:mainfrom
Conversation
adpaco-aws
force-pushed
the
bookrunner-check
branch
from
a28901c to
987d60a
Compare
celinval
reviewed
Feb 25, 2022
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
One tiny comment. Thanks for doing this so quick. :)
| # The threshold is roughly computed as: `1.05 * <number of expected failures>` | ||
| # The extra 5% allows us to account for occasional timeouts. It is reviewed and | ||
| # updated whenever the Rust toolchain version is updated. | ||
| THRESHOLD=652 |
Contributor
There was a problem hiding this comment.
nit: can we add the calculation here instead of relying on the person that is updating this?
EXPECTED=<num>
THRESHOLD=$(expr ${EXPECTED} \* 105 / 100) # Add 5% threshold.
adpaco-aws
force-pushed
the
bookrunner-check
branch
from
3dc0dde to
08b6a0f
Compare
celinval
approved these changes
Feb 25, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Add script and workflow step to check for bookrunner failures * Update bookrunner docs * Compute threshold from expected num of failures * Update expected number to current
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Add script and workflow step to check for bookrunner failures * Update bookrunner docs * Compute threshold from expected num of failures * Update expected number to current
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a CI script to check for bookrunner failures, and another step in the bookrunner workflow to call it.
Resolved issues:
Call-outs:
Testing:
How is this change tested? CI.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.