Update build workflow with cargo build#878
Merged
adpaco-aws merged 3 commits intomodel-checking:mainfrom Mar 1, 2022
Merged
Conversation
tedinski
approved these changes
Mar 1, 2022
Contributor
tedinski
left a comment
There was a problem hiding this comment.
link restrictions should be built, right up until we remove it as a binary separate from cargo-kani which will be coming before too long.
.github/actions/build/action.yml
Outdated
Comment on lines
+37
to
+39
| cargo build -p kani-compiler | ||
| cargo build -p cargo-kani | ||
| cargo build -p kani-link-restrictions |
Contributor
There was a problem hiding this comment.
should we not just cargo build?
Contributor
Author
There was a problem hiding this comment.
Yes, I thought we wanted to avoid building everything here for some reason, but that doesn't seem to be the case.
celinval
approved these changes
Mar 1, 2022
cargo-kanicargo build
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Build `cargo-kani` and `kani-link-restrictions` in build action * Update number of expected failures * Build all the things
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Build `cargo-kani` and `kani-link-restrictions` in build action * Update number of expected failures * Build all the things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates the build workflow to build
cargo-kaniandkani-link-restrictions. Changes the expected number of failures to 94.Resolved issues:
Resolves #876
Call-outs:
Building
kani-link-restrictionsappears to be necessary, otherwise I get this error:Do we need an issue for this?
Testing:
How is this change tested? CI.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.