Retry Discord API 5xx errors and handle non-JSON error bodies#87
Merged
Retry Discord API 5xx errors and handle non-JSON error bodies#87
Conversation
Cloudflare edge errors (5xx, edge-level 429s) return plain-text bodies like "upstream connect error..." or "error code: 1015" that crash a naive response.json() call. Add a tryParseJson helper and use it for all error paths so we surface the actual HTTP status/body instead of a JSON parse exception. Also add exponential backoff retry for 5xx responses, matching the existing 429 retry behavior. :house: Remote-Dev: homespace
Pulumi PreviewClick to expand preview output |
Contributor
Author
|
Direct push to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tryParseJsonhelper so Cloudflare plain-text error bodies (e.g.upstream connect error...,error code: 1015) don't crashresponse.json()in the 429/error pathsTest plan
pulumi previewsucceeds against the Discord provider