Add allowClientError to Scenario interface for expected client failures#123
Conversation
commit: |
pcarleton
left a comment
There was a problem hiding this comment.
Love it, thank you! one minor nit.
for a follow-up: I'm thinking clientOutput should actually be a mandatory argument to printing the results. so we don't have to do that existence check. If we don't have an exitCode we should likely consider it a failure, but happy to tackle that separately
Co-authored-by: Paul Carleton <paulcarletonjr@gmail.com>
|
Hi! I'm working on implementing client conformance tests for Go and just wanted to let you know that likely due to this change the |
Motivation and Context
Prior to this change, client conformance tests could fail in expected error cases because the client exited with a non-zero exit code. This behavior should be allowed and considered as passing for expected error tests.
How Has This Been Tested?
Ran the tests locally.
Breaking Changes
No previously passing test should fail as a result of this change.
Types of changes
Checklist
Additional context