fix: recurse into subdirectories when parsing conformance output#148
Merged
fix: recurse into subdirectories when parsing conformance output#148
Conversation
commit: |
parseOutputDir only read one level deep, so scenarios with '/' in their name (e.g. auth/metadata-default) were stored in nested subdirectories and never found. This caused tier-check to report 4/23 client conformance when the actual pass rate was 23/23. Also removes accidentally committed pnpm-lock.yaml.
felixweinberger
force-pushed
the
fweinberger/fix-parseoutputdir-recursion
branch
from
cc6e759 to
6a10350
Compare
pcarleton
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseOutputDirin tier-check only read one directory level deep. Scenarios with/in their name (e.g.auth/metadata-default,auth/scope-*) create nested subdirectories in the output dir, so theirchecks.jsonfiles were never found. This caused tier-check to silently report 4/23 client conformance when the actual pass rate was 23/23.Motivation and Context
All 19 auth client scenarios were invisible to tier-check scoring, making every SDK appear to fail client conformance even when all tests pass.
How Has This Been Tested
node dist/index.js tier-checkagainst typescript-sdk v1.x: client conformance goes from 4/23 (17%) to 23/23 (100%)pnpm testpassesTypes of changes
Checklist