Omit arguments from tool call with no arguments#53
Merged
pcarleton merged 1 commit intomodelcontextprotocol:mainfrom Nov 24, 2025
Merged
Conversation
commit: |
pcarleton
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR modifies the tools-call-simple-text to omit the "arguments" property in the tool call, which is not required according to the schema.
https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-06-18/schema.json#L133
This will flag server implementations that incorrectly fail tool call requests that do not include "arguments".
How Has This Been Tested?
All tests, including the modified tools-call-simple-text test, pass when run on a server using the C# MCP SDK.
Breaking Changes
No breaking change, just a slightly more strict version of the test.
Types of changes
Checklist
Additional context
This might expose a latent conformance bug in the TypeScript SDK.