Refactor client testing to use 'everything' client with scenario routing#54
Merged
Refactor client testing to use 'everything' client with scenario routing#54
Conversation
The CLI now passes both scenario name and server URL as arguments to the client command (instead of just the server URL). This enables a single "everything" client that can handle all scenarios based on the scenario name it receives. Changes: - Update executeClient() to pass scenarioName as first argument to client - Add everything-client.ts that routes to appropriate behavior based on scenario name - Update README with new usage examples and documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
5e36841 to
a8d1868
Compare
commit: |
Pass scenario name via MCP_CONFORMANCE_SCENARIO env var instead of as a positional argument. This is non-breaking for existing clients that just accept <server-url>. The env var approach is consistent with how context (including private keys for JWT auth) is already passed via MCP_CONFORMANCE_CONTEXT.
pcarleton
added a commit
that referenced
this pull request
Jan 5, 2026
Update auth-test.ts and test helper to use the new MCP_CONFORMANCE_SCENARIO env var instead of putting scenario in the context object. This aligns with the everything-client pattern from PR #54.
pcarleton
added a commit
that referenced
this pull request
Jan 5, 2026
Update auth-test.ts and testClient.ts to use MCP_CONFORMANCE_SCENARIO env var instead of scenario in context object. This aligns with PR #54.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor client testing to use scenario routing via environment variable.
Changes
everything-client.ts: Single client that routes to appropriate behavior based onMCP_CONFORMANCE_SCENARIOenv varsrc/runner/client.ts: Pass scenario name via env var instead of positional argument (non-breaking change)README.md: Updated with new usage examplesDesign Decision
The scenario name is passed via
MCP_CONFORMANCE_SCENARIOenv var rather than as a positional argument or insideMCP_CONFORMANCE_CONTEXTbecause:Usage
Test plan
initializescenario passesauth/basic-dcrscenario passesauthsuite (10 scenarios) - all pass