[WIP] Fix SSE retry warning handling in client conformance tests#1299
Closed
[WIP] Fix SSE retry warning handling in client conformance tests#1299
Conversation
The sse-retry test checks timing constraints that can vary in resource-constrained CI environments. This change allows the test to skip (pass) when there are only warnings and no actual failures, avoiding spurious test failures due to timing variations. The test now: 1. Parses the conformance test output 2. Detects if there are only warnings (0 failed, N warnings) 3. Skips the test with an explanatory message for sse-retry scenario 4. Continues to fail for actual test failures Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.