fix(client): fully collapse Output Schema and Meta panels in ToolsTab#1295
Open
SarthakB11 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(client): fully collapse Output Schema and Meta panels in ToolsTab#1295SarthakB11 wants to merge 1 commit intomodelcontextprotocol:mainfrom
SarthakB11 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Output Schema and Meta panels in the tool detail view kept rendering their JSON body inside a clipped scroll well (
max-h-[8rem] overflow-y-auto) when "collapsed", so a chunk of the panel content stayed on screen and the toggle didn't really collapse anything. The issue's screenshot shows this clearly.This PR conditionally renders each body only when the corresponding
isOutputSchemaExpanded/isMetadataExpandedflag is true. Collapsed state now shows just the header row and the Expand button, matching the user expectation in #928.The fix targets V1 (
client/src/components/ToolsTab.tsx); the issue's screenshot is from the current V1 UI even though the issue carries thev2label.Fixes #928
Test plan
npm run prettier-fixcleanclient/src/components/__tests__/ToolsTab.test.tsx, so no new test was added.