Skip to content

Add count to server response and fix Makefile paths #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sridharavinash merged 2 commits into from
Apr 24, 2025
Merged

Add count to server response and fix Makefile paths #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9ff1f
Add a count to the servers response
sridharavinash Apr 24, 2025
ea2af95
Fix run commands in Makefile to use correct main package paths
sridharavinash Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ test:
# Run the application
run:
@echo "Running $(BINARY_NAME)..."
@$(GO) run $(MAIN_PATH)
@$(GO) run $(MAIN_PACKAGE)/main.go $(MAIN_PACKAGE)/version.go

# Run the application with test environment (using fake service)
run-test:
@echo "Running $(BINARY_NAME) with test environment..."
@APP_ENV=test $(GO) run $(MAIN_PATH)
@APP_ENV=test $(GO) run $(MAIN_PACKAGE)/main.go $(MAIN_PACKAGE)/version.go

# Install dependencies
deps:
Expand Down
3 changes: 3 additions & 0 deletions internal/api/handlers/v0/servers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ type PaginatedResponse struct {
// Metadata contains pagination metadata
type Metadata struct {
NextCursor string `json:"next_cursor,omitempty"`
Count int `json:"count,omitempty"`
Total int `json:"total,omitempty"`
}

// ServersHandler returns a handler for listing registry items
Expand Down Expand Up @@ -82,6 +84,7 @@ func ServersHandler(registry service.RegistryService) http.HandlerFunc {
if nextCursor != "" {
response.Metadata = Metadata{
NextCursor: nextCursor,
Count: len(registries),
}
}

Expand Down