fix: enhance transport graceful shutdown with proper writer closure#392
Merged
jokemanfire merged 1 commit intomodelcontextprotocol:mainfrom Aug 28, 2025
Merged
fix: enhance transport graceful shutdown with proper writer closure#392jokemanfire merged 1 commit intomodelcontextprotocol:mainfrom
jokemanfire merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
- Add TransportWriter type alias for cleaner type definitions - Wrap transport writer in Option to enable proper closure - Implement close() method to drop writer and signal end of communication - Update graceful_shutdown to close transport before waiting for process exit - Improve error handling for closed transport state Addresses the graceful shutdown improvements discussed in modelcontextprotocol#347 and modelcontextprotocol#364
github-actions
bot
added
T-core
jokemanfire
approved these changes
Aug 28, 2025
Merged
takumi-earth
pushed a commit
to earthlings-dev/rmcp
that referenced
this pull request
Jan 27, 2026
…odelcontextprotocol#392) - Add TransportWriter type alias for cleaner type definitions - Wrap transport writer in Option to enable proper closure - Implement close() method to drop writer and signal end of communication - Update graceful_shutdown to close transport before waiting for process exit - Improve error handling for closed transport state Addresses the graceful shutdown improvements discussed in modelcontextprotocol#347 and modelcontextprotocol#364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I recently built an MCP stdio server that uses grcov for code coverage collection. During integration testing, I discovered that source coverage from the MCP server binary was not being generated.
After investigation, I found that LLVM profile data is not produced when an executable exits with an abnormal status.
How Has This Been Tested?
Yes. I try it out on my project.
Breaking Changes
Types of changes
Checklist
Additional context
Addresses the graceful shutdown improvements discussed in #347 and #364