Add helpers to build enum from concrete values#393
Merged
4t145 merged 1 commit intomodelcontextprotocol:mainfrom Aug 29, 2025
Merged
Add helpers to build enum from concrete values#3934t145 merged 1 commit intomodelcontextprotocol:mainfrom
4t145 merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
This allows building functions like
```rust
fn stream(resp: impl Into<ServerResult>, req_id: RequestId) -> Result<Response, UpstreamError> {
let rpc = ServerJsonRpcMessage::response(resp.into(), req_id);
```
howardjohn
force-pushed
the
helpers/into-enum
branch
from
1b012fa to
e1fcca9
Compare
Merged
takumi-earth
pushed a commit
to earthlings-dev/rmcp
that referenced
this pull request
Jan 27, 2026
…textprotocol#393) This allows building functions like ```rust fn stream(resp: impl Into<ServerResult>, req_id: RequestId) -> Result<Response, UpstreamError> { let rpc = ServerJsonRpcMessage::response(resp.into(), req_id); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This allows building functions like
How Has This Been Tested?
Manually tested
Breaking Changes
No
Types of changes
Checklist
Additional context