fix(auth): url parse is not correct#402
Merged
alexhancock merged 1 commit intomodelcontextprotocol:mainfrom Aug 29, 2025
Merged
fix(auth): url parse is not correct#402alexhancock merged 1 commit intomodelcontextprotocol:mainfrom
alexhancock merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes URL parsing issues in the OAuth authentication module by replacing string formatting with proper URL parsing to prevent double slashes in endpoint URLs.
- Introduces a helper function to properly construct endpoint URLs using URL parsing
- Replaces hardcoded "http://localhost" strings with a named constant
- Fixes the bug where
format!("{}/authorize", auth_base)could produce URLs with double slashes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The format method is not good for url.
alexhancock
approved these changes
Aug 29, 2025
Merged
takumi-earth
pushed a commit
to earthlings-dev/rmcp
that referenced
this pull request
Jan 27, 2026
The format method is not good for url.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format method is not good for url.
use
authorization_endpoint: format!("{}/authorize", auth_base)will cause the result"http://example.com//authorize"
replace with url parse will be great for avoiding this problem.
fix #397
Motivation and Context
fix url bug.
How Has This Been Tested?
No need UT.
Breaking Changes
NO
Types of changes
Checklist
Additional context