fix(tasks): #626 model task capabilities correctly#627
Merged
alexhancock merged 1 commit intomainfrom Jan 23, 2026
Merged
Conversation
40145f3 to
38aaf98
Compare
38aaf98 to
e20f6df
Compare
jamadeo
approved these changes
Jan 23, 2026
Contributor
jamadeo
left a comment
There was a problem hiding this comment.
Nice! Works on my test with goose.
|
|
||
| // Verify serialization matches expected format | ||
| let json = serde_json::to_value(&tasks).unwrap(); | ||
| assert_eq!(json["list"], serde_json::json!({})); |
Contributor
There was a problem hiding this comment.
are these really testing all that much?
Contributor
Author
There was a problem hiding this comment.
not terribly. the serialization one has value but these I agree don't add much. merging for not to not wait for another CI cycle but I will remove them on a future change.
Merged
takumi-earth
pushed a commit
to earthlings-dev/rmcp
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #626
Capabilities for tasks take the following form.
Client
Server
We were previously using booleans to model these instead of objects, causing errors during initialization between servers and clients that expressed these capabilities