feat: 2025-11-25 phase 1, includes Version, Icon, Progress#181
feat: 2025-11-25 phase 1, includes Version, Icon, Progress#181
Conversation
|
I would just like to point out that the moment something like this gets merged, it becomes much more difficult to pursue a stacked-PR approach based on my fork due to merge conflicts. |
but you were not going to merge your changes anyway |
|
@eugenepyvovarov, it's still an open question, and there is a discussion about this on the Maintainers Discord server. I just want to point this out for the record, and others can decide on how to proceed. |
09f1dae to
20d2855
Compare
| name: String, | ||
| arguments: [String: Value]? = nil, | ||
| meta: Metadata? = nil | ||
| ) throws -> RequestContext<CallTool.Result> { |
There was a problem hiding this comment.
It looks like a braking change here.
- I think it's better to have overloaded or additional versions of the func - to keep them both:
- RequestContext<CallTool.Result>
- async -> RequestContext<CallTool.Result>
- async -> (content: [Tool.Content], isError: Bool?)
- The cancellation token is not tool only related, it's request level. Maybe to simplify the current implementation keep it as advanced feature for now and provide it only via using send directly?
There was a problem hiding this comment.
Thanks for a comment. I added an overloaded version of callTool.
* feat: added Logging and Completions * feat: updated EmbeddedResource for the latest spec * chore: changed encoding of meta in Prompts to encodeIfPresent * feat: compliance tests + http server transport (#197) * feat: http server transport * feat: added http server transport * feat: removed unused files * feat: added conformance tests * feat: improved conformace testing * chore: removed redundant files
* chore: fixed unit tests * feat: added icon and progess base structs * feat: added progress notification and meta to callTool * feat: added tests * feat: simplified RequestMeta encoding/decoding * tests: added unit test to track progress * chore: rebased v0.11.x * feat: implemented cancellation * feat: added overloaded callTool method * fix: encoding Response _meta fix * chore: added old version to the versions list * feat: 2025-11-25 phase 2; added Logging and Completions (#196) * feat: added Logging and Completions * feat: updated EmbeddedResource for the latest spec * chore: changed encoding of meta in Prompts to encodeIfPresent * feat: compliance tests + http server transport (#197) * feat: http server transport * feat: added http server transport * feat: removed unused files * feat: added conformance tests * feat: improved conformace testing * chore: removed redundant files
* chore: fixed unit tests * feat: added icon and progess base structs * feat: added progress notification and meta to callTool * feat: added tests * feat: simplified RequestMeta encoding/decoding * tests: added unit test to track progress * chore: rebased v0.11.x * feat: implemented cancellation * feat: added overloaded callTool method * fix: encoding Response _meta fix * chore: added old version to the versions list * feat: 2025-11-25 phase 2; added Logging and Completions (#196) * feat: added Logging and Completions * feat: updated EmbeddedResource for the latest spec * chore: changed encoding of meta in Prompts to encodeIfPresent * feat: compliance tests + http server transport (#197) * feat: http server transport * feat: added http server transport * feat: removed unused files * feat: added conformance tests * feat: improved conformace testing * chore: removed redundant files
* Support 2025-06-18 Spec (#167) * Support OpenAI _meta for Tool * Update init * Add title and outputSchema * Concurreny issue * General fields * Add Generate Fields to Server elements * 4 tab spacing * Update Version * Elicitation * Format * More tests and inits * Elicitation in README * Fix orphaned test * Add title to more structs * Public init * Fix meta validation and make tests more generic * Format and make Result properties public again * Revert more visibility changes * feat: 2025-11-25 phase 1, includes Version, Icon, Progress (#181) * chore: fixed unit tests * feat: added icon and progess base structs * feat: added progress notification and meta to callTool * feat: added tests * feat: simplified RequestMeta encoding/decoding * tests: added unit test to track progress * chore: rebased v0.11.x * feat: implemented cancellation * feat: added overloaded callTool method * fix: encoding Response _meta fix * chore: added old version to the versions list * feat: 2025-11-25 phase 2; added Logging and Completions (#196) * feat: added Logging and Completions * feat: updated EmbeddedResource for the latest spec * chore: changed encoding of meta in Prompts to encodeIfPresent * feat: compliance tests + http server transport (#197) * feat: http server transport * feat: added http server transport * feat: removed unused files * feat: added conformance tests * feat: improved conformace testing * chore: removed redundant files * feat/2025-11-25: sampling, elicitation, roots (#198) * feat: Roots implementation * feat: added unit testing * feat: improved unit tests and fixed NetworkTransport crash * feat: implemented sampling and elicitation * feat: improved sampling tests * feat: improved elicitation tests * feat: improved confirmance tests * feat: improved Prompts unit tests * feat: removed test code * feat: updated conformance tests * chore: removed redundant commas * chore: removed 6.0.3 swift version from ci * chore: improved unit tests a little bit * chore: update README.md * chore: add server progress tracking example to README.md * chore: updated README.md * chore: updated transports table formatting * chore: updated MockNetworkConnection --------- Co-authored-by: Austin Evans <austinjevans@me.com> Co-authored-by: yehorsobko <yehorsobko@macpaw.com>
* Enable building with the Swift Linux SDK (modelcontextprotocol#151) * Update README to document support for Alpine Linux (modelcontextprotocol#153) * Adopt strict concurrency for project (modelcontextprotocol#157) * Adopt strict concurrency for project * Fix one warning related to that * Add version-specific manifest for Swift 6.0 --------- Co-authored-by: Alexey Ivashko <a_ivashko@apple.com> Co-authored-by: Mattt Zmuda <mattt@me.com> * Make `Tool.description` optional (modelcontextprotocol#160) * Make Tool.description optional * Make description parameter in Tool initializer optional * fix: allow description field to be absent from `Tool` (modelcontextprotocol#159) * fix: allow description field to be absent from `Tool` * description field is not a requried field of Tool * Apply suggestions from code review * Update Tests/MCPTests/ToolTests.swift --------- Co-authored-by: Mattt <mattt@me.com> * Add Mac Catalyst to target dependencies for EventSource. (modelcontextprotocol#163) * chore: update licensing to Apache 2.0 for new contributions (modelcontextprotocol#177) * Add SECURITY.md with GitHub Security Advisories guidance (modelcontextprotocol#200) * V0.11.x (modelcontextprotocol#199) * Support 2025-06-18 Spec (modelcontextprotocol#167) * Support OpenAI _meta for Tool * Update init * Add title and outputSchema * Concurreny issue * General fields * Add Generate Fields to Server elements * 4 tab spacing * Update Version * Elicitation * Format * More tests and inits * Elicitation in README * Fix orphaned test * Add title to more structs * Public init * Fix meta validation and make tests more generic * Format and make Result properties public again * Revert more visibility changes * feat: 2025-11-25 phase 1, includes Version, Icon, Progress (modelcontextprotocol#181) * chore: fixed unit tests * feat: added icon and progess base structs * feat: added progress notification and meta to callTool * feat: added tests * feat: simplified RequestMeta encoding/decoding * tests: added unit test to track progress * chore: rebased v0.11.x * feat: implemented cancellation * feat: added overloaded callTool method * fix: encoding Response _meta fix * chore: added old version to the versions list * feat: 2025-11-25 phase 2; added Logging and Completions (modelcontextprotocol#196) * feat: added Logging and Completions * feat: updated EmbeddedResource for the latest spec * chore: changed encoding of meta in Prompts to encodeIfPresent * feat: compliance tests + http server transport (modelcontextprotocol#197) * feat: http server transport * feat: added http server transport * feat: removed unused files * feat: added conformance tests * feat: improved conformace testing * chore: removed redundant files * feat/2025-11-25: sampling, elicitation, roots (modelcontextprotocol#198) * feat: Roots implementation * feat: added unit testing * feat: improved unit tests and fixed NetworkTransport crash * feat: implemented sampling and elicitation * feat: improved sampling tests * feat: improved elicitation tests * feat: improved confirmance tests * feat: improved Prompts unit tests * feat: removed test code * feat: updated conformance tests * chore: removed redundant commas * chore: removed 6.0.3 swift version from ci * chore: improved unit tests a little bit * chore: update README.md * chore: add server progress tracking example to README.md * chore: updated README.md * chore: updated transports table formatting * chore: updated MockNetworkConnection --------- Co-authored-by: Austin Evans <austinjevans@me.com> Co-authored-by: yehorsobko <yehorsobko@macpaw.com> --------- Co-authored-by: Tobias <t089@users.noreply.github.com> Co-authored-by: Mattt <mattt@me.com> Co-authored-by: Alexey Ivashko <mcivashko@gmail.com> Co-authored-by: Alexey Ivashko <a_ivashko@apple.com> Co-authored-by: Yifan Liu <liuyf1117@hotmail.com> Co-authored-by: Semen Kudriavtsev <sam@kudr.me> Co-authored-by: adam jones <domdomegg+git@gmail.com> Co-authored-by: Den Delimarsky <53200638+localden@users.noreply.github.com> Co-authored-by: Maksym Mova <maks.mova@gmail.com> Co-authored-by: Austin Evans <austinjevans@me.com> Co-authored-by: yehorsobko <yehorsobko@macpaw.com>
This update brings Icon to be used in Tools, Resources and Prompts. Protocol version is also updated, it doesn't mean this PR has all the features of new protocol, since it is intermediate work in progress it's ok to update it now. Progress is added to the CallToolRequest. Cancellation support.
Motivation and Context
The idea is to bring latest protocol compatibility step by step. This step brings relatively simple changes while maintaining overall codebase structure and style.
How Has This Been Tested?
I tested it locally by creating stdio mcp servers both in TS and Swift.
Breaking Changes
I guess in this part of work there's no any
Types of changes
Checklist