Skip to content

fix atomic continuation guards#210

Closed
doozMen wants to merge 1 commit intomodelcontextprotocol:mainfrom
doozMen:fix/atomic-continuation-guards
Closed

fix atomic continuation guards#210
doozMen wants to merge 1 commit intomodelcontextprotocol:mainfrom
doozMen:fix/atomic-continuation-guards

Conversation

@doozMen
Copy link

@doozMen doozMen commented Mar 17, 2026

No description provided.

@doozMen doozMen force-pushed the fix/atomic-continuation-guards branch from 157281e to 649449f Compare March 17, 2026 11:42
@doozMen doozMen force-pushed the fix/atomic-continuation-guards branch 2 times, most recently from 55fc9d2 to 9975609 Compare March 18, 2026 09:07
fix rebase with upstream

fix rebase with upstream

fix continuation (#9)

Co-authored-by: Stijn Willems <stijn@promptping.ai>
@doozMen doozMen force-pushed the fix/atomic-continuation-guards branch from 9975609 to 730cc61 Compare March 18, 2026 09:07
@doozMen doozMen marked this pull request as draft March 18, 2026 09:10
@doozMen
Copy link
Author

doozMen commented Mar 18, 2026

Closing this PR — it bundles too many unrelated changes (platform minimum bump, atomic continuation guards, withBatch generics) without description, tests, or justification. Will file a proper issue upstream documenting the Swift 6.3 compiler error and discuss the right approach.

@doozMen doozMen closed this Mar 18, 2026
Copy link
Author

@doozMen doozMen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the ai slob was not supposed to be a pr yet. I'm trying to get it build on swift 6.3-dev snapshot but also not sure yet there is a bug this pr was a glitch. sorry

@doozMen
Copy link
Author

doozMen commented Mar 18, 2026

Filed #211 as a proper issue with root cause analysis, compiler output, and a suggested fix that preserves the current platform minimums (macOS 13+/iOS 16+) using an NSLock-based wrapper instead of Mutex from Synchronization (which would require macOS 15+/iOS 18+).

See also #203 for the related @MainActor continuation guard issue in the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant