-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
P2Moderate issues affecting some users, edge cases, potentially valuable featureModerate issues affecting some users, edge cases, potentially valuable featureenhancementRequest for a new feature that's not currently supportedRequest for a new feature that's not currently supportedready for workEnough information for someone to start working onEnough information for someone to start working on
Description
Context
In PR #1360 (client conformance testing), there's a TODO comment in src/conformance/helpers/withOAuthRetry.ts:30-31:
// TODO: this retry logic should be incorporated into the typescript SDKThe conformance test helper implements OAuth retry logic that:
- Handles 401/403 responses by attempting re-authentication
- Extracts
resourceMetadataUrlandscopefrom WWW-Authenticate headers - Automatically retries the request after obtaining fresh tokens
- Handles the authorization code flow including redirect handling
Suggestion
Consider incorporating this retry pattern into the SDK's withOAuth middleware or as a separate utility, so SDK users don't need to implement this logic themselves.
Related
- PR feat: add client conformance testing #1360: feat: add client conformance testing
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Moderate issues affecting some users, edge cases, potentially valuable featureModerate issues affecting some users, edge cases, potentially valuable featureenhancementRequest for a new feature that's not currently supportedRequest for a new feature that's not currently supportedready for workEnough information for someone to start working onEnough information for someone to start working on