Only use path-based discovery URLs from the authorization server to discover metadata#1070
Merged
pcarleton merged 2 commits intomodelcontextprotocol:mainfrom Nov 3, 2025
Conversation
…oot (if supplied)
pcarleton
requested changes
Nov 3, 2025
| type: 'oauth' | ||
| }); | ||
|
|
||
| // Root path: https://example.com/.well-known/oauth-authorization-server |
Member
There was a problem hiding this comment.
left a comment on the issue #1069
Let's change the path-based URL list to just be:
/.well-known/oauth-authorization-server${pathname}/.well-known/openid-configuration/${pathname}${pathname}/.well-known/openid-configuration
And not have the root fallbacks.
9 tasks
dclark27
pushed a commit
to socotra/typescript-sdk
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use path-based discovery URLs from an authorization server discovered from
/.well-known/oauth-protected-resource'sauthorization_serversvalue.Motivation and Context
See #1069.
If the root URL contains an OAuth authorization server in addition to the path-based URL supplied from
/.well-known/oauth-protected-resource, the incorrect authorization server is relied upon to continue the OAuth flow.How Has This Been Tested?
Updated unit tests.
Breaking Changes
I do not believe so as the first choice has not been changed which means if no path is set, reading from
https://auth.example.com/.well-known/oauth-authorization-servershould work as expected.Types of changes
Checklist
Additional context
Is this behavior documented anywhere else?