fix(server): application/json header for notifictions#1373
Conversation
🦋 Changeset detectedLatest commit: 17d8fd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
@mattzcarey, I'm curious about the reasoning for this, since I'm referring to the TypeScript SDK in my development of this Swift SDK. Since notification responses have an empty body, specifying a content type seems unnecessary, and it isn't mentioned in the spec. The TypeScript SDK also doesn't include a content type for DELETE 200 responses. Are there clients that expect this in practice? |
Hey this closed an issue which was effecting people using the Java client. Please see the issue this closed |
|
Happy to revisit this if you think it was misplaced. |
This reverts commit 8b6e455.
|
It looks like the Java client now handles the previous (correct) behavior of the TypeScript HTTP server correctly and will log a warning about a non-compliant response with the new behavior from this PR. So unless I'm misunderstanding something, this should probably be reverted. |
closes #1356
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context