Skip to content

Conversation

@beutlich
Copy link
Member

@beutlich beutlich commented Nov 11, 2020

Check if realpath fails for non-existing path and add getcwd fallback. Especially, do not call ModelicaError for non-existing path.

Closes #3660 for OM#6204.

Check if realpath fails for non-existing path and add getcwd fallback. Especially, do not call ModelicaError for non-existing path.
@beutlich beutlich added bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources labels Nov 11, 2020
@beutlich beutlich added this to the MSL4.1.0 milestone Nov 11, 2020
@beutlich beutlich self-assigned this Nov 11, 2020
@beutlich beutlich requested a review from casella November 16, 2020 21:22
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.

Copy link
Member

@sjoelund sjoelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realise you already fixed this. It was on my list for this week. I tested the code and it works fine.

@beutlich beutlich removed the request for review from casella November 17, 2020 16:26
@beutlich beutlich merged commit 3c50a41 into modelica:master Nov 17, 2020
@beutlich beutlich deleted the do-no-error-if-realpath-fails branch November 17, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modelica.Utilities.Files.createDirectory fails if the directory does not exist

3 participants