Skip to content

Conversation

@HansOlsson
Copy link
Contributor

@HansOlsson HansOlsson commented Feb 18, 2022

Primarily done using a new flag of updateModelicaAnnotations in Dymola.
But Modelica/Electrical/Machines/Icons/(Quasi|)StaticTransformer.mo was also manually converted to be more line-based texts (makes future changes more logical), and some part of Modelica.Electrical are missing here - need to investigate.
Closes #3951

Note that Modelica/Electrical/Machines/Icons/(Quasi|)StaticTransformer.mo was converted to be line-based.
Closes modelica#3951
@HansOlsson HansOlsson requested a review from AHaumer February 18, 2022 10:31
@HansOlsson
Copy link
Contributor Author

For TwoPort and FourPort I believe the gradients were a plain mistake, and removed them.

@casella
Copy link
Contributor

casella commented Feb 19, 2022

I'm not really sure what this is all about, am I supposed to know?

@HansOlsson
Copy link
Contributor Author

HansOlsson commented Feb 20, 2022

I'm not really sure what this is all about, am I supposed to know?

Perhaps, the change in Modelica.Fluid.Vessels shouldn't change the diagrams seen in Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWith3InletOutletArraysWithEvaporatorCondensor
Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWithTopPorts
for Dymola; and possibly make it look better in other tools.

@beutlich beutlich added the icon Issues addresses the icon graphics label Feb 22, 2022
@HansOlsson
Copy link
Contributor Author

To clarify for @casella @christiankral it is intended to solve the #3951 that found that

Some classes have Icon annotations where there is a fillPattern which should give a gradient, but they have lineColor explicitly equal to fillColor which results in a solid fill instead.

In Dymola such classes are rendered as if lineColor is black which gives a good visual gradient, and this PR just changes to use black lineColor instead (except some that shouldn't have gradient).

@HansOlsson
Copy link
Contributor Author

If you use Dymola and you don't see any change in

@casella

  • Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWith3InletOutletArraysWithEvaporatorCondensor (icon has tank with gradient)
  • Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWithTopPorts (icon has tank with gradient)

@christiankral @AHaumer

  • Modelica.Electrical.Machines.BasicMachines.Components.PartialAirGapDC (icon has bar with gradient)
  • Modelica.Electrical.Machines.BasicMachines.Transformers (icon has bars with gradients)
  • Modelica.Electrical.Analog.Interfaces.FourPin (diagram has arrows - they should be solid, no gradients)

etc you can accept it.

For other tools it may be the same, or the older version may lack the gradients (for the ones that should have them).

Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the electrical and magnetic icons and they all look good.

@MartinOtter MartinOtter merged commit e34b4a9 into modelica:master Oct 7, 2022
@dietmarw dietmarw added this to the MSL4.1.0 milestone Oct 7, 2022
@beutlich beutlich changed the title Almost automatically updated to have correct gradient. Update icons almost automatically updated to have correct gradient Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icon Issues addresses the icon graphics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing gradient colors in some Icons

6 participants