-
Notifications
You must be signed in to change notification settings - Fork 176
Update icons almost automatically updated to have correct gradient #3952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note that Modelica/Electrical/Machines/Icons/(Quasi|)StaticTransformer.mo was converted to be line-based. Closes modelica#3951
|
For TwoPort and FourPort I believe the gradients were a plain mistake, and removed them. |
|
I'm not really sure what this is all about, am I supposed to know? |
Perhaps, the change in Modelica.Fluid.Vessels shouldn't change the diagrams seen in Modelica.Fluid.Examples.AST_BatchPlant.BaseClasses.TankWith3InletOutletArraysWithEvaporatorCondensor |
|
To clarify for @casella @christiankral it is intended to solve the #3951 that found that Some classes have Icon annotations where there is a fillPattern which should give a gradient, but they have lineColor explicitly equal to fillColor which results in a solid fill instead. In Dymola such classes are rendered as if lineColor is black which gives a good visual gradient, and this PR just changes to use black lineColor instead (except some that shouldn't have gradient). |
|
If you use Dymola and you don't see any change in
etc you can accept it. For other tools it may be the same, or the older version may lack the gradients (for the ones that should have them). |
christiankral
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the electrical and magnetic icons and they all look good.
Primarily done using a new flag of updateModelicaAnnotations in Dymola.
But Modelica/Electrical/Machines/Icons/(Quasi|)StaticTransformer.mo was also manually converted to be more line-based texts (makes future changes more logical), and some part of Modelica.Electrical are missing here - need to investigate.
Closes #3951