Skip to content

Conversation

@klausschuch
Copy link
Collaborator

@klausschuch klausschuch commented May 6, 2025

fixes for #25

@klausschuch klausschuch force-pushed the pu/klausschuch/improve_pointcloud branch from eca06ac to 02f7c48 Compare May 6, 2025 11:50
@klausschuch klausschuch force-pushed the pu/klausschuch/improve_pointcloud branch from e65d0a6 to 8b76d28 Compare May 19, 2025 16:00
@chrbertsch chrbertsch requested review from chrbertsch and otronarp May 20, 2025 13:42
Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, Klaus!

Copy link
Member

@otronarp otronarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (except for the mentioned missing closing of ---- ).

[source, xml]
----
include::examples/irregular2d_modelDescription.xml[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a closing ---- ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

@klausschuch klausschuch merged commit b08456f into modelica:main May 26, 2025
1 check passed
@klausschuch klausschuch deleted the pu/klausschuch/improve_pointcloud branch May 26, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants