Convenience functionality for aliases and clocks #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2025
Merged
Contributor
modelonrobinandersson
left a comment
modelonrobinandersson
left a comment
There was a problem hiding this comment.
Well done! Just minor nitpick.
I also wasn't sure about the RELEASE NOTE entry:
- Checking if a variable has clocks: `fmi3_import_get_variable_is_clocked, it says "... has clocks" but the function is called "... is clocked", not sure if we want to align this further?
Co-authored-by: Robin Andersson <robin.andersson@modelon.com>
modelonrobinandersson
approved these changes
Jun 24, 2025
PeterMeisrimelModelon
added a commit
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the string parsing changes: This is obviously not quite as unified as it could be, but hopefully a step in the right direction.