Minizip: use localtime_r instead of localtime on POSIX systems #202
Conversation
|
@modelonrobinandersson This is a small fix, where our static analysis (CodeQL) complained about use of |
|
Thank you @tbleher! Could you add a changelog entry as well? |
You mean in |
|
@tbleher you are correct, |
Thank you for the clarification 👍 I have added a line there, I hope it is suitable. |
|
@tbleher looks good! When rebasing just note that version |
`localtime` is not thread-safe on POSIX systems, meaning that the values might be corrupted if another thread in the same process calls `localtime` at the same time. Use `localtime_r` instead, which is thread-safe.
tbleher
force-pushed
the
minizip-use-localtime_r
branch
from
1c7fe5d to
df90398
Compare
|
I have rebased the changes unto current |
modelonrobinandersson
merged commit bb232e8
into
modelon-community:master
2 participants
localtimeis not thread-safe on POSIX systems, meaning that the values might be corrupted if another thread in the same process callslocaltimeat the same time. Uselocaltime_rinstead, which is thread-safe.