-
Notifications
You must be signed in to change notification settings - Fork 21
feat(cmd): set raw flag default to true for attach, build, upload #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: chlins <chlins.zhang@gmail.com>
Summary of ChangesHello @chlins, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the default behavior of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the default behavior for the raw flag to true across the build, attach, and upload commands, which is a good step towards simplifying the CLI. My review includes suggestions to improve the clarity of the help messages for these flags.
More importantly, I've identified a significant inconsistency: the config structs in pkg/config/attach.go, pkg/config/build.go, and pkg/config/upload.go still initialize the Raw field to false in their respective New...() functions. This mismatch between the flag defaults and the config struct defaults can lead to subtle bugs. It's highly recommended to update the default values in the config structs to true to ensure consistent behavior.
aftersnow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…delpack#323) Signed-off-by: chlins <chlins.zhang@gmail.com>
…delpack#323) Signed-off-by: chlins <chlins.zhang@gmail.com>
This pull request updates the default behavior for the
rawflag across three CLI commands:build,attach, andupload. The most important change is that therawflag is now enabled by default for these commands, meaning model artifact layers will be processed in raw format unless explicitly disabled.Default flag behavior updates:
rawflag totruein thebuildcommand, so model artifact layers are built in raw format by default (cmd/build.go).rawflag totruein theattachcommand, so model artifact layers are attached in raw format by default (cmd/attach.go).rawflag totruein theuploadcommand, so model artifact layers are uploaded in raw format by default (cmd/upload.go).