Skip to content

Conversation

@chlins
Copy link
Member

@chlins chlins commented Nov 10, 2025

This pull request updates the default behavior for the raw flag across three CLI commands: build, attach, and upload. The most important change is that the raw flag is now enabled by default for these commands, meaning model artifact layers will be processed in raw format unless explicitly disabled.

Default flag behavior updates:

  • Changed the default value of the raw flag to true in the build command, so model artifact layers are built in raw format by default (cmd/build.go).
  • Changed the default value of the raw flag to true in the attach command, so model artifact layers are attached in raw format by default (cmd/attach.go).
  • Changed the default value of the raw flag to true in the upload command, so model artifact layers are uploaded in raw format by default (cmd/upload.go).

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins added the enhancement New feature or request label Nov 10, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @chlins, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default behavior of the raw flag across three core CLI commands: build, attach, and upload. By setting the raw flag to true by default, the system will now process model artifact layers in their raw format without requiring explicit user input, thereby streamlining the user experience for common operations involving model artifacts.

Highlights

  • Default raw flag behavior: The raw flag is now set to true by default for the attach, build, and upload CLI commands, meaning model artifact layers will be processed in raw format unless explicitly disabled.
  • Streamlined Model Artifact Handling: This change simplifies the workflow for users who prefer raw format processing, as it removes the need to explicitly set the raw flag for these common operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default behavior for the raw flag to true across the build, attach, and upload commands, which is a good step towards simplifying the CLI. My review includes suggestions to improve the clarity of the help messages for these flags.

More importantly, I've identified a significant inconsistency: the config structs in pkg/config/attach.go, pkg/config/build.go, and pkg/config/upload.go still initialize the Raw field to false in their respective New...() functions. This mismatch between the flag defaults and the config struct defaults can lead to subtle bugs. It's highly recommended to update the default values in the config structs to true to ensure consistent behavior.

Copy link
Contributor

@aftersnow aftersnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aftersnow aftersnow merged commit d54a264 into main Nov 10, 2025
8 checks passed
@aftersnow aftersnow deleted the feat/enable-raw-by-default branch November 10, 2025 06:40
avinashsingh77 pushed a commit to avinashsingh77/modctl that referenced this pull request Dec 22, 2025
avinashsingh77 pushed a commit to avinashsingh77/modctl that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants