-
Notifications
You must be signed in to change notification settings - Fork 21
feat: support modelfile generate with exclude patterns #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @qiumuyang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable --exclude flag for the modelfile generate command, allowing users to filter out files and directories using glob patterns. The implementation is robust, featuring a dedicated PathFilter utility with comprehensive test coverage. My feedback includes suggestions for enhancing the documentation and command-line help text to improve user experience, along with a minor code simplification. Overall, this is a well-executed feature.
6112d71 to
fbddd0d
Compare
Signed-off-by: qmy <qiumuyang.qmy@antgroup.com>
Signed-off-by: qmy <qiumuyang.qmy@antgroup.com>
fbddd0d to
8969207
Compare
|
@aftersnow Please help to take a look, thanks! |
aftersnow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
* feat: enhance modelfile generate with exclude patterns Signed-off-by: qmy <qiumuyang.qmy@antgroup.com> * docs(getting-started): update modelfile generate usage Signed-off-by: qmy <qiumuyang.qmy@antgroup.com> --------- Signed-off-by: qmy <qiumuyang.qmy@antgroup.com> Co-authored-by: qmy <qiumuyang.qmy@antgroup.com>
This PR adds a new
--excludeflag tomodctl modelfile generate, allowing users to exclude files and directories using glob patterns.Limitation: The implementation relies on Go’s
filepath.Match, therefore it supports only the basic glob syntax (*,?,[]).Closes #330.