Skip to content

Conversation

@qiumuyang
Copy link
Contributor

This PR adds a new --exclude flag to modctl modelfile generate, allowing users to exclude files and directories using glob patterns.

Limitation: The implementation relies on Go’s filepath.Match, therefore it supports only the basic glob syntax (*, ?, []).

Closes #330.

@gemini-code-assist
Copy link

Summary of Changes

Hello @qiumuyang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the modctl modelfile generate command by adding the capability to exclude specific files and directories from the generated modelfile. This provides users with greater control over the contents of their model artifacts, allowing them to easily filter out unwanted items like temporary files, build outputs, or sensitive data based on glob patterns.

Highlights

  • New --exclude flag: Introduced a new --exclude flag to the modctl modelfile generate command, allowing users to specify glob patterns for files and directories to be excluded from the generated modelfile.
  • Glob Pattern Support: The exclusion functionality relies on Go's filepath.Match, supporting basic glob syntax including *, ?, and [] for pattern matching.
  • Path Filtering Logic: Implemented a new PathFilter utility to process and match exclusion patterns efficiently during the modelfile generation process.
  • Documentation Update: Updated the getting-started.md documentation to include instructions and an example for using the new --exclude flag.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable --exclude flag for the modelfile generate command, allowing users to filter out files and directories using glob patterns. The implementation is robust, featuring a dedicated PathFilter utility with comprehensive test coverage. My feedback includes suggestions for enhancing the documentation and command-line help text to improve user experience, along with a minor code simplification. Overall, this is a well-executed feature.

qmy added 2 commits November 19, 2025 15:48
Signed-off-by: qmy <qiumuyang.qmy@antgroup.com>
Signed-off-by: qmy <qiumuyang.qmy@antgroup.com>
@chlins
Copy link
Member

chlins commented Nov 25, 2025

@aftersnow Please help to take a look, thanks!

Copy link
Contributor

@aftersnow aftersnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aftersnow aftersnow merged commit bc5518b into modelpack:main Nov 25, 2025
8 checks passed
avinashsingh77 pushed a commit to avinashsingh77/modctl that referenced this pull request Dec 22, 2025
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
avinashsingh77 pushed a commit to avinashsingh77/modctl that referenced this pull request Dec 22, 2025
avinashsingh77 pushed a commit to avinashsingh77/modctl that referenced this pull request Dec 22, 2025
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
avinashsingh77 pushed a commit to avinashsingh77/modctl that referenced this pull request Dec 22, 2025
* feat: enhance modelfile generate with exclude patterns

Signed-off-by: qmy <qiumuyang.qmy@antgroup.com>

* docs(getting-started): update modelfile generate usage

Signed-off-by: qmy <qiumuyang.qmy@antgroup.com>

---------

Signed-off-by: qmy <qiumuyang.qmy@antgroup.com>
Co-authored-by: qmy <qiumuyang.qmy@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ignore patterns in modelfile generate

3 participants