Skip to content

[bugfix] fix contiguous#8158

Merged
Jintao-Huang merged 1 commit intomodelscope:mainfrom
Jintao-Huang:fix_contiguous
Mar 2, 2026
Merged

[bugfix] fix contiguous#8158
Jintao-Huang merged 1 commit intomodelscope:mainfrom
Jintao-Huang:fix_contiguous

Conversation

@Jintao-Huang
Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug by ensuring that tensors maintain a contiguous memory layout after transpose operations within the qwen3_next.py and qwen3_5.py models. This change is crucial for preventing potential issues with subsequent tensor manipulations that expect contiguous data, thereby improving the stability and correctness of the model's computations.

Highlights

  • Bug Fix: Add .contiguous() calls after transpose operations in qwen3_next.py and qwen3_5.py to ensure correct tensor memory layout for subsequent operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • swift/megatron/model/gpts/qwen3_next.py
    • Ensured tensor contiguity after transpose operation.
  • swift/megatron/model/mm_gpts/qwen3_5.py
    • Ensured tensor contiguity after transpose operation.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request applies a bugfix across two model files, qwen3_next.py and qwen3_5.py. The change involves adding a .contiguous() call after a transpose operation on the res tensor. This ensures the tensor has a contiguous memory layout before being passed to reduce_scatter_to_sequence_parallel_region, which likely prevents runtime errors related to tensor strides. The fix is consistent and correctly applied in both locations.

@Jintao-Huang Jintao-Huang merged commit 652dd34 into modelscope:main Mar 2, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants