Skip to content

fix cookbook#152

Merged
tastelikefeet merged 8 commits intomodelscope:mainfrom
tastelikefeet:fix/0411-1
Apr 11, 2026
Merged

fix cookbook#152
tastelikefeet merged 8 commits intomodelscope:mainfrom
tastelikefeet:fix/0411-1

Conversation

@tastelikefeet
Copy link
Copy Markdown
Collaborator

PR type

  • Bug Fix
  • New Feature
  • Document Updates
  • More Models or Datasets Support

PR information

Write the detail information belongs to this PR.

Experiment results

Paste your experiment result here(if needed).

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several cookbook examples with revised GPU configurations and model IDs, and refactors the loss calculation logic to support separate training and evaluation statuses. It also includes bug fixes for variable references in the vLLM engine and sequence length calculations. Reviewers identified an inconsistency where some metrics still hardcode training status during evaluation and suggested more robust error handling when dynamically loading model architectures from configurations.

Comment thread src/twinkle/model/transformers/transformers.py
Comment thread src/twinkle/template/qwen3_5_vl.py
@tastelikefeet
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces multimodal distillation support for OlympiadBench, updates model configurations across several examples, and enhances the core framework's handling of evaluation status, weight synchronization, and vLLM sampling. Key improvements include a new check for uniform batch distribution to prevent hangs and corrected sequence length indexing. Review feedback highlights several critical issues: a potential TypeError in weight synchronization when model_keys is null, a ValueError in template label concatenation caused by numpy array operations, a missing self parameter in a template method, and ineffective type checking for tensor data in the uniformity check.

Comment thread src/twinkle/model/transformers/transformers.py
Comment thread src/twinkle/template/base.py Outdated
Comment thread src/twinkle/template/base.py Outdated
Comment thread src/twinkle/infra/__init__.py
@tastelikefeet tastelikefeet merged commit 21912d5 into modelscope:main Apr 11, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants