Fix MoE multi-lora training#161
Merged
tastelikefeet merged 4 commits intomodelscope:mainfrom Apr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for configurable target_modules in multi-LoRA implementations for both Megatron and Transformers, defaulting to 'all-linear'. It also adds 'Qwen3.6' to the model template mapping and implements logic to preserve the 'all-linear' configuration during model saving. Feedback focuses on ensuring state consistency during the save process by using a try...finally block and restoring performance-critical checks in activate_adapter to avoid redundant calls to set_adapter.
Yunnglin
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).