A small refactor, move 4d mask to processor#167
Merged
tastelikefeet merged 2 commits intomodelscope:mainfrom Apr 18, 2026
Merged
A small refactor, move 4d mask to processor#167tastelikefeet merged 2 commits intomodelscope:mainfrom
tastelikefeet merged 2 commits intomodelscope:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the NPU causal 4D mask removal logic by moving it from the Megatron model class to the processor base class. The processor now receives the model configuration to determine if the mask should be dropped. A review comment suggests optimizing the retrieval of the model configuration in the forward_backward method by using self.strategy.config directly instead of unwrapping the model to improve efficiency.
addsubmuldiv
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).