Skip to content

Fix multi lora #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastelikefeet merged 1 commit into from
Apr 21, 2026
Merged

Fix multi lora #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/twinkle/model/multi_lora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ def _lora_A(x, *args, **kwargs):

def _get_weight_tensors(self):
tensors = self._get_weight_tensors_origin()
return [t[:_lora.tenant_config.r, :] for t in tensors]
return [t[:_lora.tenant_config.r, :].contiguous() for t in tensors]

lora_A._get_weight_tensors_origin = lora_A._get_weight_tensors
lora_A._get_weight_tensors = MethodType(_get_weight_tensors, lora_A)
Expand All @@ -353,7 +353,7 @@ def _lora_B(x, *args, **kwargs):

def _get_weight_tensors(self):
tensors = self._get_weight_tensors_origin()
return [t[:, :_lora.tenant_config.r] for t in tensors]
return [t[:, :_lora.tenant_config.r].contiguous() for t in tensors]

lora_B._get_weight_tensors_origin = lora_B._get_weight_tensors
lora_B._get_weight_tensors = MethodType(_get_weight_tensors, lora_B)
Expand Down Expand Up @@ -572,13 +572,13 @@ def save_lora_converter(self, name, parameter, adapter_name):
if _param is None:
pass
elif 'embedding_A' in name:
_param = _param[:, :_lora.tenant_config.r]
_param = _param[:, :_lora.tenant_config.r].clone()
elif 'embedding_B' in name:
_param = _param[:_lora.tenant_config.r, :]
_param = _param[:_lora.tenant_config.r, :].clone()
elif '_A' in name:
_param = _param[:_lora.tenant_config.r, :]
_param = _param[:_lora.tenant_config.r, :].clone()
elif '_B' in name:
_param = _param[:, :_lora.tenant_config.r]
_param = _param[:, :_lora.tenant_config.r].clone()
name = name.replace(f'.{_lora.adapter_name}.', '.')
return name, _param
else:
Expand Down
Loading