Support of strides in the convolutional layers #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdp1
requested review from
Riccardo231 and
milancurcic
and removed request for
milancurcic
Member
|
Yes, it's exactly how I would do it, thanks Jeremie. |
Riccardo231
approved these changes
Oct 25, 2025
Collaborator
|
I think it is a good implementation. Thanks for your job |
Collaborator
|
I'd like to offer my support whenever it is needed, feel free to contact me, right now I'm busy to develop improvements on my own but I can cooperate with someone else |
jvdp1
commented
Oct 31, 2025
jvdp1
commented
Oct 31, 2025
Collaborator
Author
|
@milancurcic @Riccardo231 Pending a comment/question, this PR is ready for review and/or to be merged. |
Member
|
Thank you @jvdp1 and sorry again for the delay. Will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to support strides in the convolutional layers
@Riccardo231 @milancurcic does this approach make sense? If yes, I will continue its implementation.