fix(createpackages): avoid creating invalid escape characters#1055
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1055 +/- ##
=============================================
+ Coverage 71.769% 72.845% +1.075%
=============================================
Files 225 221 -4
Lines 51895 51119 -776
=============================================
- Hits 37245 37238 -7
+ Misses 14650 13881 -769
|
|
Hey @mwtoews, just wanted to give you a heads up that these modflow 6 classes that you modified are generated automatically from definition files that describe the package contents. So making changes to the docstrings won't have a long-lasting effect. We've tried to note this at the top of these files with: Agreed that it would be good to get this fixed, but it will require a different approach. |
|
Déjà vu #700 |
8732ec5 to
77fed19
Compare
77fed19 to
e590edf
Compare
|
@langevin-usgs I tracked down the main bug to remove escape characters, which is why this PR has been rewritten Some of the math is overkill, e.g. |
|
Hey @mwtoews, I don't see how the change you made in this PR removes the :math: string. Am I missing something? Are there changes required to createpackages.py that are not included here? And for |
* Fix latex escape characters in description processing with math * Replace latex characters to plaintext for Python * Replace several other latex items involving \citep and \ref that are specific to mfio.pdf
e590edf to
7cb3f46
Compare
|
@langevin-usgs only As for |
This tidies up a few DeprecationWarning messages from docstrings, and expand LaTeX commands like
\mfto MODFLOW 6.Flake8's W605 can be removed.