Update pytest framework#1493
Merged
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
* use pytest-benchmark's builtin profiling capability instead of manual implementation * remove requires_exe(mf6) from test_mf6.py tests that don't run models/simulations * add @requires_spatial_reference marker to conftest.py (for tests depending on spatialreference.org) * try both importlib.import_module and pkg_resources.get_distribution in @requires_pkg marker * mark test_lgr.py::test_simple_lgr_model_from_scratch as flaky (occasional forrtl error (65): floating invalid) * split test_export.py::test_polygon_from_ij into network-bound and non-network-bound cases * add comments to flaky tests with links to potentially similar issues * add timeouts to CI jobs (10min for build, lint, & smoke, 45min for test, 90min for daily jobs) * remove unneeded markers from pytest.ini * match profiling/benchmarking test files in pytest.ini * mark get-modflow tests as flaky (modflowpy#1489 (comment)) * cache benchmark results in daily CI and compare with prior runs * various tidying/cleanup
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Aug 10, 2022
* use pytest-benchmark's builtin profiling capability instead of manual implementation * remove requires_exe(mf6) from test_mf6.py tests that don't run models/simulations * add @requires_spatial_reference marker to conftest.py (for tests depending on spatialreference.org) * try both importlib.import_module and pkg_resources.get_distribution in @requires_pkg marker * mark test_lgr.py::test_simple_lgr_model_from_scratch as flaky (occasional forrtl error (65): floating invalid) * split test_export.py::test_polygon_from_ij into network-bound and non-network-bound cases * add comments to flaky tests with links to potentially similar issues * add timeouts to CI jobs (10min for build, lint, & smoke, 45min for test, 90min for daily jobs) * remove unneeded markers from pytest.ini * match profiling/benchmarking test files in pytest.ini * mark get-modflow tests as flaky (modflowpy#1489 (comment)) * cache benchmark results in daily CI and compare with prior runs * various tidying/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest framework changes include:
pytest-benchmark's builtin profiling capability instead of manual implementationDEVELOPER.mdto reflect aboverequires_exe("mf6")fromtest_mf6.pytests that don't run models/simulations@requires_spatial_referencemarker toconftest.py(for tests depending on spatialreference.org)test_export.py::test_polygon_from_ijinto network-bound and non-network-bound cases (and use marker above)importlib.import_moduleandpkg_resources.get_distributionin@requires_pkgmarkerpymakevsmfpymaketest_lgr.py::test_simple_lgr_model_from_scratchas flaky (occasional forrtl error (65): floating invalid)pytest.ini(profile,benchmark)pytest.iniprofile_*.pybenchmark_*.py*_profile*.py*_benchmark*.pyget-modflowscript tests as flaky again due to internal github API egress issuesCI changes include:
benchmark--<python version>becausematrix.oswas incorrectly used with no job matrix, now fixed withrunner.osso that all benchmark artifacts are named asbenchmark-<platform>-<python version>)