Skip to content

Debug Codecov#1496

Closed
wpbonelli wants to merge 1 commit into
modflowpy:developfrom
wpbonelli:debug-codecov
Closed

Debug Codecov#1496
wpbonelli wants to merge 1 commit into
modflowpy:developfrom
wpbonelli:debug-codecov

Conversation

@wpbonelli
Copy link
Copy Markdown
Member

@wpbonelli wpbonelli commented Aug 12, 2022

Upload coverage reports on pull_request as well as push events to fix inaccurate codecov bot comments on PRs.

Also:

  • don't measure & upload coverage for smoke tests, regression & example tests, and benchmarks
    • smoke tests and benchmarks are subsets of the standard test suite
    • example scripts/notebooks are not included in coverage measurements (only the flopy module is)
    • excluding regression tests does not seem to change coverage appreciably (as seems appropriate — ideally the standard test suite should exercise everything?) and I can plan to add a few cases to make up any omissions
  • decrease coverage precision from 3 to 2 decimal places to avoid small/spurious deltas
  • update to codecov-action@v3

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 12, 2022

Codecov Report

Merging #1496 (65698fb) into develop (65698fb) will not change coverage.
The diff coverage is n/a.

❗ Current head 65698fb differs from pull request most recent head b565730. Consider uploading reports for the commit b565730 to get more accurate results

@@            Coverage Diff            @@
##           develop     #1496   +/-   ##
=========================================
  Coverage   72.461%   72.461%           
=========================================
  Files          250       250           
  Lines        54005     54005           
=========================================
  Hits         39133     39133           
  Misses       14872     14872           

@wpbonelli wpbonelli force-pushed the debug-codecov branch 7 times, most recently from 26e87d2 to d9132cc Compare August 12, 2022 19:57
@wpbonelli wpbonelli marked this pull request as ready for review August 12, 2022 19:59
@wpbonelli wpbonelli force-pushed the debug-codecov branch 2 times, most recently from d4ba120 to 35bcdb0 Compare August 15, 2022 15:48
Copy link
Copy Markdown
Contributor

@jdhughes-dev jdhughes-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* don't upload coverage after smoke tests, benchmarks, regression & example tests
* upload coverage on PRs (previously only on push) to fix coverage comments
* update to codecov-action v3
* decrease coverage precision to 2 decimal places (avoid small deltas)
* update ci.yml references to commit.yml
@wpbonelli
Copy link
Copy Markdown
Member Author

Think I got all the references to ci.yml.

@wpbonelli
Copy link
Copy Markdown
Member Author

Merged into #1495

@wpbonelli wpbonelli closed this Aug 17, 2022
@wpbonelli wpbonelli deleted the debug-codecov branch September 5, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants